On 10/9/19 5:32 PM, Brendan Higgins wrote: > On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote: >> In case of master pending state, it should not trigger a master >> command, otherwise data could be corrupted because this H/W shares >> the same data buffer for slave and master operations. It also means >> that H/W command queue handling is unreliable because of the buffer >> sharing issue. To fix this issue, it clears command queue if a >> master command is queued in pending state to use S/W solution >> instead of H/W command queue handling. Also, it refines restarting >> mechanism of the pending master command. >> >> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support") >> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> > > Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > > We don't have any multi-master setups, can we get a Tested-by? I've applied the patch to my tree and I'm looking for a minipack BMC (milti-master) to test the patch. Will come back with results tomorrow. Cheers, Tao > Wolfram, since this is a bugfix, can we get this in 5.4? > > Thanks! >