On Thu, Oct 03, 2019 at 02:49:22PM +0300, Talel Shenhar wrote: > Document Amazon's Annapurna Labs Memory Controller EDAC SoC binding. > > Signed-off-by: Talel Shenhar <talel@xxxxxxxxxx> > --- > .../bindings/edac/amazon,al-mc-edac.yaml | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml > > diff --git a/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml > new file mode 100644 > index 0000000..33da051 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/amazon,al-mc-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amazon's Annapurna Labs Memory Controller EDAC > + > +maintainers: > + - Talel Shenhar <talel@xxxxxxxxxx> > + - Talel Shenhar <talelshenhar@xxxxxxxxx> > + > +description: | > + EDAC node is defined to describe on-chip error detection and correction for > + Amazon's Annapurna Labs Memory Controller. > + > +properties: > + > + compatible: > + - const: "amazon,al-mc-edac" Fails 'make dt_binding_check'. Drop the '-' as a property is not a list. The "" are also unnecessary. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + edac@f0080000 { > + compatible = "amazon,al-mc-edac"; > + reg = <0x0 0xf0080000 0x0 0x00010000>; > + interrupt-parent = <&amazon_al_system_fabric>; > + interrupt-names = "ue"; Need to document the name or drop as -names on a single entry is pointless. > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; > + }; > -- > 2.7.4 >
