On Tue, 8 Oct 2019 at 11:34, Andrew Jeffery <andrew@xxxxxxxx> wrote: > > The AST2500 has an explicit gate for the RMII RCLK for each of the two > MACs. > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx> > --- > include/dt-bindings/clock/aspeed-clock.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h > index f43738607d77..64e245fb113f 100644 > --- a/include/dt-bindings/clock/aspeed-clock.h > +++ b/include/dt-bindings/clock/aspeed-clock.h > @@ -39,6 +39,8 @@ > #define ASPEED_CLK_BCLK 33 > #define ASPEED_CLK_MPLL 34 > #define ASPEED_CLK_24M 35 > +#define ASPEED_CLK_GATE_MAC1RCLK 36 > +#define ASPEED_CLK_GATE_MAC2RCLK 37 Calling these ASPEED_CLK_GATE breaks the pattern the rest of the driver has in using that name for the clocks that are registered as struct aspeed_clk_gate clocks. Do you think we should drop the GATE_ to match the existing clocks? > > #define ASPEED_RESET_XDMA 0 > #define ASPEED_RESET_MCTP 1 > -- > 2.20.1 >