On Wed, Sep 04, 2019 at 04:51:04PM +0800, Biwen Li wrote: > The rtc is on i2c2 bus(hardware), not on i2c1 channel 3, > so correct it > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx> This looks a like a fix. Do we need a Fixes tag for it? > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index de6ef39f3118..6c0540ad9c59 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -133,11 +133,6 @@ > vcc-supply = <&sb_3v3>; > }; > > - rtc@51 { > - compatible = "nxp,pcf2129"; > - reg = <0x51>; > - }; > - > eeprom@56 { > compatible = "atmel,24c512"; > reg = <0x56>; > @@ -166,6 +161,14 @@ > }; > }; > > +&i2c1 { > + status = "okay"; Please have a newline between properties and child node. Shawn > + rtc@51 { > + compatible = "nxp,pcf2129"; > + reg = <0x51>; > + }; > +}; > + > &sai1 { > status = "okay"; > }; > -- > 2.17.1 >