On Tue, Sep 24, 2019 at 12:53 PM Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx> wrote: > As mentioned for your other patch set where the regulator driver makes use of > GPIOs for control, I think here you should probably have pinctrl to define > alternate functions of each GPIO. It seems that mostly pinctrl drivers support > GPIO functionality rather than the other way, so maybe that's the direction > to go in? Maybe Linus has some input on this too. Usually the both functions can coexist but the simplest if often to put them in the same driver. drivers/pinctrl/pinctrl-stmfx.c Documentation/devicetree/bindings/pinctrl/pinctrl-stmfx.txt is a recent slow bus driver doing this. Yours, Linus Walleij