On Fri, Oct 4, 2019 at 2:40 AM Michal Vokáč <michal.vokac@xxxxxxxxx> wrote: > > On 03. 10. 19 21:09, Rob Herring wrote: > > On Tue, Oct 1, 2019 at 9:29 AM Michal Vokáč <michal.vokac@xxxxxxxxx> wrote: > >> > >> Convert the mpr121 binding to DT schema format using json-schema. > >> > >> Signed-off-by: Michal Vokáč <michal.vokac@xxxxxxxxx> > >> --- > >> Changes since v1: > >> - Extract the common input properties into the input.yaml schema. > >> - Fix the wakeup-source description. > >> - Fix the example to pass validation. Put the mpr121 device sub-node > >> into a i2c {} node. > >> > >> Rob, the linux,keycodes property is not valid as it is. > >> If I put the minItems and maxItems into the common schema, it is valid > >> and the min/max length check works fine. What could be wrong? > >> > >> The error is not very specific.. > > > > That's a side effect of an 'allOf' somewhere in the meta-schema. > > > >> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml > >> SCHEMA Documentation/devicetree/bindings/processed-schema.yaml > >> /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml: ignoring, error in schema 'linux,keycodes' > >> warning: no schema found in file: /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml > >> /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/processed-schema.yaml' failed > >> make[3]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255 > >> /home/vokac/development/sources/linux-fslc/Makefile:1264: recipe for target 'dt_binding_check' failed > > > > I'm working on a fix for this. It's a problem in the meta-schema. > > OK, thanks a lot! I've committed an update to the meta-schema. Please update dtschema and it should work for you. Rob