Hi Sakari, On Fri, Oct 04, 2019 at 12:23:36PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Thu, Oct 03, 2019 at 03:25:03PM +0530, Manivannan Sadhasivam wrote: > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > > supports I2C interface for programming and MIPI CSI-2 for sensor output. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > Could you remove the unneeded ret variable from imx290_power_on() and > unneeded goto in the same function? > yep, sure. > The MAINTAINERS entry belongs to the first patch adding new files. > You mean the bindings patch? If then, sorry no. Usually the devicetree bindings belongs to a separate patch and that is what perferred by Rob. I prefer the MAINTAINERS entry in a separate patch but I've seen subsystems maintainers asking to squash it with the driver patch. But squashing it with bindings patch seems weird to me. Thanks, Mani > Then I think this is good. > > -- > Regards, > > Sakari Ailus
