On Thu, 2019-10-03 at 10:59 -0500, Rob Herring wrote: > On Wed, Oct 2, 2019 at 5:27 AM Philippe Schenker > <philippe.schenker@xxxxxxxxxxx> wrote: > > On Tue, 2019-10-01 at 17:05 -0500, Rob Herring wrote: > > > On Fri, Sep 20, 2019 at 09:54:11AM +0200, Marcel Ziswiler wrote: > > > > From: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx> > > > > > > > > Add display timings for the following 3 display panels > > > > manufactured > > > > by > > > > Logic Technologies Limited: > > > > > > > > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch > > > > Display > > > > 7" Parallel [1] > > > > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch > > > > Display > > > > 7" > > > > Parallel [2] > > > > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch > > > > Display > > > > 10.1" LVDS [3] > > > > > > > > Those panels may also be distributed by Endrich Bauelemente > > > > Vertriebs > > > > GmbH [4]. > > > > > > > > [1] > > > > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf > > > > [2] > > > > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf > > > > [3] > > > > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf > > > > [4] > > > > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30 > > > > > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx> > > > > > > > > --- > > > > > > > > drivers/gpu/drm/panel/panel-simple.c | 65 > > > > ++++++++++++++++++++++++++++ > > > > 1 file changed, 65 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > > b/drivers/gpu/drm/panel/panel-simple.c > > > > index 28fa6ba7b767..42bd0de25167 100644 > > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > > @@ -2034,6 +2034,62 @@ static const struct panel_desc lg_lp129qe > > > > = { > > > > }, > > > > }; > > > > > > > > +static const struct display_timing > > > > logictechno_lt161010_2nh_timing > > > > = { > > > > + .pixelclock = { 26400000, 33300000, 46800000 }, > > > > + .hactive = { 800, 800, 800 }, > > > > + .hfront_porch = { 16, 210, 354 }, > > > > + .hback_porch = { 46, 46, 46 }, > > > > + .hsync_len = { 1, 20, 40 }, > > > > + .vactive = { 480, 480, 480 }, > > > > + .vfront_porch = { 7, 22, 147 }, > > > > + .vback_porch = { 23, 23, 23 }, > > > > + .vsync_len = { 1, 10, 20 }, > > > > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > > > > + DISPLAY_FLAGS_DE_HIGH | > > > > DISPLAY_FLAGS_PIXDATA_POSEDGE | > > > > + DISPLAY_FLAGS_SYNC_POSEDGE, > > > > +}; > > > > + > > > > +static const struct panel_desc logictechno_lt161010_2nh = { > > > > + .timings = &logictechno_lt161010_2nh_timing, > > > > + .num_timings = 1, > > > > + .size = { > > > > + .width = 154, > > > > + .height = 86, > > > > + }, > > > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > > > > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > > > > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, > > > > +}; > > > > + > > > > +static const struct display_timing > > > > logictechno_lt170410_2whc_timing > > > > = { > > > > + .pixelclock = { 68900000, 71100000, 7340000 }, > > > > + .hactive = { 1280, 1280, 1280 }, > > > > + .hfront_porch = { 23, 60, 71 }, > > > > + .hback_porch = { 23, 60, 71 }, > > > > + .hsync_len = { 15, 40, 47 }, > > > > + .vactive = { 800, 800, 800 }, > > > > + .vfront_porch = { 5, 7, 10 }, > > > > + .vback_porch = { 5, 7, 10 }, > > > > + .vsync_len = { 6, 9, 12 }, > > > > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > > > > + DISPLAY_FLAGS_DE_HIGH | > > > > DISPLAY_FLAGS_PIXDATA_POSEDGE | > > > > + DISPLAY_FLAGS_SYNC_POSEDGE, > > > > +}; > > > > + > > > > +static const struct panel_desc logictechno_lt170410_2whc = { > > > > + .timings = &logictechno_lt170410_2whc_timing, > > > > + .num_timings = 1, > > > > + .size = { > > > > + .width = 217, > > > > + .height = 136, > > > > + }, > > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > > > > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > > > > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, > > > > +}; > > > > + > > > > static const struct drm_display_mode mitsubishi_aa070mc01_mode > > > > = { > > > > .clock = 30400, > > > > .hdisplay = 800, > > > > @@ -3264,6 +3320,15 @@ static const struct of_device_id > > > > platform_of_match[] = { > > > > }, { > > > > .compatible = "lg,lp129qe", > > > > .data = &lg_lp129qe, > > > > + }, { > > > > + .compatible = "logictechno,lt161010-2nhc", > > > > + .data = &logictechno_lt161010_2nh, > > > > + }, { > > > > + .compatible = "logictechno,lt161010-2nhr", > > > > + .data = &logictechno_lt161010_2nh, > > > > + }, { > > > > + .compatible = "logictechno,lt170410-2whc", > > > > + .data = &logictechno_lt170410_2whc, > > > > > > The vendor prefix wasn't documented, but the compatible string and > > > rest > > > already are? > > > > Marcel added the vendor prefix in the first patch of the series [1] > > Right, but where's the panel's binding documentation with the above > compatible strings documented? > That one is indeed missing, we will provide that week. Thanks for pointing this out! Philippe
