Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yannick

On 9/30/19 4:45 PM, Yannick Fertré wrote:
Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
This device supports 2 different addresses (0x2a and 0x38)
depending on the display  board version (MB1407).

Signed-off-by: Yannick Fertré <yannick.fertre@xxxxxx>
---
  arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
  1 file changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
index 20ea601..527bb75 100644
--- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
@@ -61,6 +61,29 @@
  	};
  };
+&i2c1 {
+	touchscreen@2a {
+		compatible = "focaltech,ft6236";
+		reg = <0x2a>;
+		interrupts = <2 2>;
+		interrupt-parent = <&gpiof>;
+		interrupt-controller;
+		touchscreen-size-x = <480>;
+		touchscreen-size-y = <800>;
+		status = "okay";
+	};
+	touchscreen@38 {
+		compatible = "focaltech,ft6236";
+		reg = <0x38>;
+		interrupts = <2 2>;
+		interrupt-parent = <&gpiof>;
+		interrupt-controller;
+		touchscreen-size-x = <480>;
+		touchscreen-size-y = <800>;
+		status = "okay";
+	};
+};

I'm not confident by this duplication. We should only support the latest revision of the MB1407. I understand the need but my fear is to duplicate this node each time we have a new revision (and imagine if we do that for all i2c devices).

regards
alex


  &ltdc {
  	status = "okay";



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux