RE: [PATCH v2 8/9] arm64: dts: renesas: hihope-rzg2-ex: Add LVDS support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thanks for the feedback.

> Subject: Re: [PATCH v2 8/9] arm64: dts: renesas: hihope-rzg2-ex: Add LVDS
> support
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Wed, Oct 02, 2019 at 11:08:25AM +0100, Biju Das wrote:
> > This patch adds LVDS support for RZ/G2[MN] boards.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > ---
> >  V1-->V2
> >    * Incorporated Laurent's review comments
> > ---
> >  arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi | 29
> +++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > index 70f9a2a..1c7ef69 100644
> > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > @@ -51,6 +51,34 @@
> >  	status = "okay";
> >  };
> >
> > +&gpio1 {
> > +	/*
> > +	 * When GP1_20 is LOW LVDS0 is connected to the LVDS connector
> > +	 * When GP1_20 is HIGH LVDS0 is connected to the LT8918L
> > +	 */
> > +	lvds-connector-en-gpio {
> > +		gpio-hog;
> > +		gpios = <20 GPIO_ACTIVE_HIGH>;
> > +		output-low;
> > +		line-name = "lvds-connector-en-gpio";
> > +	};
> > +};
> > +
> > +&lvds0 {
> > +	/* Please include the lvds panel dtsi file and uncomment the below
> line
> 
> /* should be on a line of its own.
> 
> > +	 * to enable lvds panel connected to RZ/G2[MN] boards.
> 
> Maybe s/lvds/LVDS/ and s/dtsi/.dtsi/ ? Up to you.

OK. Will change this.

> > +	 */
> > +
> > +	/* status = "okay"; */
> > +
> > +	ports {
> > +		port@1 {
> > +			lvds_connector: endpoint {
> > +			};
> > +		};
> > +	};
> > +};
> > +
> >  &pciec0 {
> >  	status = "okay";
> >  };
> > @@ -103,3 +131,4 @@
> >
> >  	status = "okay";
> >  };
> > +

It is a mistake.  Will take out.

> And this seems unrelated. With those little issues fixed,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 
> --
> Regards,
> 
> Laurent Pinchart




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux