Hello, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Wed, 2 Oct 2019 14:30:22 +0200: > Maxim's max1027/29/31 series returns the measured voltages with a > resolution of 10 bits. There is a very similar series, max1227/29/31 > which works very similarly but uses a resolution of 12 bits. Prepare > the support for these chips by turning the 'depth' into a macro > parameter instead of hardcoding it everywhere. Also reorganize just a > bit the macros at the top to avoid repeating tens of lines when adding > support for a new chip. > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > --- > drivers/iio/adc/max1027.c | 81 +++++++++++++++++++-------------------- > 1 file changed, 39 insertions(+), 42 deletions(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index f9b473ee6711..fc75764a6fd7 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -78,12 +78,15 @@ static const struct of_device_id max1027_adc_dt_ids[] = { > { .compatible = "maxim,max1027" }, > { .compatible = "maxim,max1029" }, > { .compatible = "maxim,max1031" }, > + { .compatible = "maxim,max1227" }, > + { .compatible = "maxim,max1229" }, > + { .compatible = "maxim,max1231" }, Just spotted a mistake here: the addition of these three lines, while harmless, should have come in patch 5/7. Let me respin the series with this corrected. Thanks and sorry for the noise, Miquèl