On Sat, Apr 19, 2014 at 09:30:51PM +0200, Pavel Machek wrote: > > Add OMAP SSI driver to the HSI subsystem. > > > > The Synchronous Serial Interface (SSI) is a legacy version > > of HSI. As in the case of HSI, it is mainly used to connect > > Application engines (APE) with cellular modem engines (CMT) > > in cellular handsets. > > > > It provides a multichannel, full-duplex, multi-core communication > > with no reference clock. The OMAP SSI block is capable of reaching > > speeds of 110 Mbit/s. > > > > Signed-off-by: Carlos Chinea <carlos.chinea@xxxxxxxxx> > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > > > + bool wktest:1; /* FIXME: HACK to be removed */ > > + bool wkin_cken:1; /* Workaround */ > > There is more thanone FIXME in the code. It may be better to fix after > merge... I would prefer to keep them in there and have a look after the merge. Most FIXMEs in the code are for the wakeline test and some concern the timings. Since the current code works I would prefer to add it to the mainline kernel and tackle this afterwards. > > +DEFINE_SIMPLE_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n"); > > + > > +static int __init ssi_debug_add_port(struct omap_ssi_port *omap_port, > > + struct dentry *dir) > > +{ > > A little strange indentation. Is it intentional? > > [...] (more ugly indentation cases) Fixed in v4. -- Sebastian
Attachment:
signature.asc
Description: Digital signature