Dear Gregory CLEMENT, On Fri, 25 Apr 2014 16:07:01 +0200, Gregory CLEMENT wrote: > +#define USB3_MAX_WINDOWS 4 > +#define USB3_WIN_CTRL(w) (0x0 + ((w) * 8)) > +#define USB3_WIN_BASE(w) (0x4 + ((w) * 8)) > + > +static void __init mv_usb3_conf_mbus_windows(void __iomem *base, > + const struct mbus_dram_target_info *dram) That's a nitpick, but the name of this function looks like it was copy/pasted from the Marvell LSP, and isn't very consistent with the other function name. What about: xhci_mvebu_mbus_config() instead, or something like that? > +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev) I believe this should give you a warning about section mismatch: you have a non-init function calling an __init function, no? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
