Re: [PATCH] arm: dts: am43x-clock: add tbclk data for ehrpwm.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/25/2014 11:55 AM, Sourav Poddar wrote:
We need "tbclk" clock data for the functioning of ehrpwm
module. Hence, populating the required clock information
in clock dts file.

Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx>
---
  arch/arm/boot/dts/am43xx-clocks.dtsi |   48 ++++++++++++++++++++++++++++++++++
  drivers/clk/ti/clk-43xx.c            |    6 +++++
  2 files changed, 54 insertions(+)

diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
index 142009c..54f68e8 100644
--- a/arch/arm/boot/dts/am43xx-clocks.dtsi
+++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
@@ -87,6 +87,54 @@
  		clock-mult = <1>;
  		clock-div = <1>;
  	};
+
+	ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";

Should be ti,gate-clock.

+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <0>;

Should be ti,bit-shift.

+		reg = <0x44e10664 0x4>;

Should be reg = <0x664>. Mainline kernel uses offsets for clock data, not absolute register addresses.

Similar comments for the rest of the patch.

-Tero

+	};
+
+	ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";
+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <1>;
+		reg = <0x44e10664 0x4>;
+	};
+
+	ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";
+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <2>;
+		reg = <0x44e10664 0x4>;
+	};
+
+	ehrpwm3_tbclk: ehrpwm3_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";
+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <3>;
+		reg = <0x44e10664 0x4>;
+	};
+
+	ehrpwm4_tbclk: ehrpwm4_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";
+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <4>;
+		reg = <0x44e10664 0x4>;
+	};
+
+	ehrpwm5_tbclk: ehrpwm5_tbclk@44e10664 {
+		#clock-cells = <0>;
+		compatible = "gate-clock";
+		clocks = <&dpll_per_m2_ck>;
+		bit-shift = <5>;
+		reg = <0x44e10664 0x4>;
+	};
  };
  &prcm_clocks {
  	clk_32768_ck: clk_32768_ck {
diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
index 67c8de5..527a43d 100644
--- a/drivers/clk/ti/clk-43xx.c
+++ b/drivers/clk/ti/clk-43xx.c
@@ -105,6 +105,12 @@ static struct ti_dt_clk am43xx_clks[] = {
  	DT_CLK(NULL, "func_12m_clk", "func_12m_clk"),
  	DT_CLK(NULL, "vtp_clk_div", "vtp_clk_div"),
  	DT_CLK(NULL, "usbphy_32khz_clkmux", "usbphy_32khz_clkmux"),
+	DT_CLK("48300200.ehrpwm", "tbclk", "ehrpwm0_tbclk"),
+	DT_CLK("48302200.ehrpwm", "tbclk", "ehrpwm1_tbclk"),
+	DT_CLK("48304200.ehrpwm", "tbclk", "ehrpwm2_tbclk"),
+	DT_CLK("48306200.ehrpwm", "tbclk", "ehrpwm3_tbclk"),
+	DT_CLK("48308200.ehrpwm", "tbclk", "ehrpwm4_tbclk"),
+	DT_CLK("4830a200.ehrpwm", "tbclk", "ehrpwm5_tbclk"),
  	{ .node_name = NULL },
  };



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux