Hi Biju, On Tue, Sep 17, 2019 at 3:12 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Basic support for the RZ/G2N (R8A774B1) SoC. Added placeholders > to avoid compilation error with the common platform code. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > + avb: ethernet@e6800000 { > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; According to the documentation, RZ/G2N does not have the stream buffer, so the second register block should be omitted. > + /* placeholder */ > + }; The rest looks OK, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds