On Fri, 20 Sep 2019 20:02:58 -0700, Florian Fainelli wrote: > On 9/20/2019 6:11 PM, Jakub Kicinski wrote: > > On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote: > >> The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > >> which are enums of mode strings. > >> > >> The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > >> enum (except for 1 or 2). But in general, there may be a case where > >> 'mac-mode' becomes more generic and is moved as part of phylib or netdev. > >> > >> In any case, the 'mac-mode' field should be made an enum, and it also makes > >> sense to just reference the 'phy-connection-type' from > >> 'ethernet-controller.yaml'. That will also make it more future-proof for new > >> modes. > >> > >> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > > > Applied, thank you! > > > > FWIW I had to add the Fixes tag by hand, either ozlabs patchwork or my > > git-pw doesn't have the automagic handling there, yet. > > AFAICT the ozlabs patchwork instance does not do it, but if you have > patchwork administrative rights (the jango administration panel I mean) > then it is simple to add the regular expression to the list of tags that > patchwork already recognized. Had tried getting that included by > default, but it also counted all of those tags and therefore was not > particularly fine grained: > > https://lists.ozlabs.org/pipermail/patchwork/2017-January/003910.html Curious, it did seem to have counted the Fixes in the 'F' field on the web UI but git-pw didn't pull it down 🤔 linux$ git checkout 92974a1d006ad8b30d53047c70974c9e065eb7df Note: checking out '92974a1d006ad8b30d53047c70974c9e065eb7df'. [...] linux$ git pw patch apply 1163199 --signoff 11:41 linux$ git show commit ac964661384b93ff3c9839c6d56f293195d54b4e (HEAD) Author: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> Date: Tue Sep 17 13:30:52 2019 +0300 dt-bindings: net: dwmac: fix 'mac-mode' type The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', which are enums of mode strings. The 'dwmac' driver supports almost all modes declared in the 'phy-mode' enum (except for 1 or 2). But in general, there may be a case where 'mac-mode' becomes more generic and is moved as part of phylib or netdev. In any case, the 'mac-mode' field should be made an enum, and it also makes sense to just reference the 'phy-connection-type' from 'ethernet-controller.yaml'. That will also make it more future-proof for new modes. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Signed-off-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> 11:41 linux$
