On 9/19/19 14:58, Krzysztof Kozlowski wrote: > On Thu, 19 Sep 2019 at 14:49, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: >> On 9/19/19 10:22, Krzysztof Kozlowski wrote: >>> Wasn't this issue introduced in 5/9? It looks weird to fix it here... >> It has not been introduced by 5/9, the issue was there already before >> my patch, there was even no remove() callback where OF node references >> could be dropped. > > I see. Then please put it as first patch. You should not mix bugfixes > with features. If mixing, be sure they can be applied before the > features. I will see if it is worth the effort to rebase this patch. I didn't bother with that because this sound card driver is not used in mainline (there is no related dts changes) and the patch is a fix for minor bug which I found just before posting first version of the patch series. -- Thanks, Sylwester