Re: [PATCH 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller

[Xingyu Chen <xingyu.chen@xxxxxxxxxxx>]

Hi, Neil
Thanks for your review

On 2019/9/18 20:39, Neil Armstrong wrote:
> Hi,
>
> On 18/09/2019 14:12, Xingyu Chen wrote:
> > Add DT bindings for the Meson-A1 SoC Reset Controller include file,
> > and also slightly update documentation.
> >
> > Signed-off-by: Xingyu Chen <xingyu.chen@xxxxxxxxxxx>
> > Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
> > ---
> >   .../bindings/reset/amlogic,meson-reset.txt         |  4 +-
>
> The reset bindings has been moved to yaml, either rebase on linux-next or wait for v5.4-rc1 :
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next/+/refs/tags/next-20190917/Documentation/devicetree/bindings/reset/amlogic%2Cmeson-reset.yaml
>
> NeilI will fix it in next version.
>
> >   include/dt-bindings/reset/amlogic,meson-a1-reset.h | 59 ++++++++++++++++++++++
> >   2 files changed, 61 insertions(+), 2 deletions(-)
> >   create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-reset.h
> >
> > diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt
> > index 28ef6c2..011151a 100644
> > --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt
> > +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt
> > @@ -5,8 +5,8 @@ Please also refer to reset.txt in this directory for common reset
> >   controller binding usage.
> >   
> >   Required properties:
> > -- compatible: Should be "amlogic,meson8b-reset", "amlogic,meson-gxbb-reset" or
> > -	"amlogic,meson-axg-reset".
> > +- compatible: Should be "amlogic,meson8b-reset", "amlogic,meson-gxbb-reset",
> > +	"amlogic,meson-axg-reset" or "amlogic,meson-a1-reset".
> >   - reg: should contain the register address base
> >   - #reset-cells: 1, see below
> >   
> > diff --git a/include/dt-bindings/reset/amlogic,meson-a1-reset.h b/include/dt-bindings/reset/amlogic,meson-a1-reset.h
> > new file mode 100644
> > index 00000000..8d76a47
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/amlogic,meson-a1-reset.h
> > @@ -0,0 +1,59 @@
> > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > + *
> > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
> > + * Author: Xingyu Chen <xingyu.chen@xxxxxxxxxxx>
> > + *
> > + */
> > +
> > +#ifndef _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H
> > +#define _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H
> > +
> > +/* RESET0 */
> > +#define RESET_AM2AXI_VAD		1
> > +#define RESET_PSRAM			4
> > +#define RESET_PAD_CTRL			5
> > +#define RESET_TEMP_SENSOR		7
> > +#define RESET_AM2AXI_DEV		8
> > +#define RESET_SPICC_A			10
> > +#define RESET_MSR_CLK			11
> > +#define RESET_AUDIO			12
> > +#define RESET_ANALOG_CTRL		13
> > +#define RESET_SAR_ADC			14
> > +#define RESET_AUDIO_VAD			15
> > +#define RESET_CEC			16
> > +#define RESET_PWM_EF			17
> > +#define RESET_PWM_CD			18
> > +#define RESET_PWM_AB			19
> > +#define RESET_IR_CTRL			21
> > +#define RESET_I2C_S_A			22
> > +#define RESET_I2C_M_D			24
> > +#define RESET_I2C_M_C			25
> > +#define RESET_I2C_M_B			26
> > +#define RESET_I2C_M_A			27
> > +#define RESET_I2C_PROD_AHB		28
> > +#define RESET_I2C_PROD			29
> > +
> > +/* RESET1 */
> > +#define RESET_ACODEC			32
> > +#define RESET_DMA			33
> > +#define RESET_SD_EMMC_A			34
> > +#define RESET_USBCTRL			36
> > +#define RESET_USBPHY			38
> > +#define RESET_RSA			42
> > +#define RESET_DMC			43
> > +#define RESET_IRQ_CTRL			45
> > +#define RESET_NIC_VAD			47
> > +#define RESET_NIC_AXI			48
> > +#define RESET_RAMA			49
> > +#define RESET_RAMB			50
> > +#define RESET_ROM			53
> > +#define RESET_SPIFC			54
> > +#define RESET_GIC			55
> > +#define RESET_UART_C			56
> > +#define RESET_UART_B			57
> > +#define RESET_UART_A			58
> > +#define RESET_OSC_RING			59
> > +
> > +/* RESET2 Reserved */
> > +
> > +#endif
>
> .