* Tero Kristo <t-kristo@xxxxxx> [190917 06:49]: > On 17/09/2019 05:15, Ankur Tyagi wrote: > > Sitara technical reference manual numbers GPIO from 0 whereas > > in code GPIO are numbered from 1. > > > > Changes since v1: > > - Combine changes in single patch to avoid compilation failure > > - Update AM4 GPIO numbers as well > > So this is still not quite right, split am3 / am4 to their separate patches, > there is no need to combine those two. > > Also, you still introduce a compile breakage between this patch and the DT > patch. > > Tony, any thoughts on this? I would just leave the things as is, as the > existing setup works just fine. We just have a cosmetic issue of having the > index off-by-one compared to TRM on the clocks layer, and it is not visible > to user either as we have gpio0-3 nodes in the DT. Nobody except the main > gpio node should touch the gpio clkctrl clocks. I commented a bit on the newer version "[PATCH v3 1/2] clk: ti: am3: Update AM3 GPIO number as per datasheet". If there's a real bug lurking around we should fix that first. Regards, TOny
