> Subject: Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the > ARM SMC/HVC mailbox > > On Wed, Sep 18, 2019 at 3:53 AM Peng Fan <peng.fan@xxxxxxx> wrote: > > > > > > > > > > + > > > > > + "#mbox-cells": > > > > > + const: 1 > > > > > > > > Why is this "1"? What is this number used for? It used to be the > > > > channel ID, > > > but since you are describing a single channel controller only, this > > > should be 0 now. > > > > > > > Yes. I overlooked it and actually queued the patch for pull request. > > > > In Documentation/devicetree/bindings/mailbox/mailbox.txt > > #mbox-cells: Must be at least 1. > > > > So I use 1 here, 0 not work. Because of_mbox_index_xlate expect at least 1 > here. > > So I need modify Documentation/devicetree/bindings/mailbox/mailbox.txt > > and add xlate for smc mailbox? > > > No, you just can not use the generic xlate() provided by the api. > Please implement your own xlate() that requires no argument. ok. Will add xlate. Thanks, Peng. > > Cheers!
