Hi Rob, Thank you for your review. I will fix in v2 the things that you pointed out. 2019年9月17日(火) 22:12 Rob Herring <robh@xxxxxxxxxx>: > > On Tue, Sep 17, 2019 at 7:06 AM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > > > > Convert Renesas Interrupt Controller bindings documentation to json-schema. > > > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > --- > > .../bindings/interrupt-controller/renesas,irqc.txt | 48 ---------------- > > .../interrupt-controller/renesas,irqc.yaml | 64 ++++++++++++++++++++++ > > 2 files changed, 64 insertions(+), 48 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.txt > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > > [...] > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > > new file mode 100644 > > index 0000000..f08d368 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > > @@ -0,0 +1,64 @@ > > License. The default for existing bindings is GPL-2.0-only. If Renesas > is the only copyright holder, then please license as (GPL-2.0-only OR > BSD-2-Clause). > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interrupt-controller/renesas,irqc.yaml# > > +$schema: http://devicetree.org/meta-schemas/interrupts.yaml# > > + > > +title: DT bindings for the R-Mobile/R-Car/RZ/G interrupt controller > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,irqc-r8a73a4 # R-Mobile APE6 > > + - renesas,irqc-r8a7743 # RZ/G1M > > + - renesas,irqc-r8a7744 # RZ/G1N > > + - renesas,irqc-r8a7745 # RZ/G1E > > + - renesas,irqc-r8a77470 # RZ/G1C > > + - renesas,irqc-r8a7790 # R-Car H2 > > + - renesas,irqc-r8a7791 # R-Car M2-W > > + - renesas,irqc-r8a7792 # R-Car V2H > > + - renesas,irqc-r8a7793 # R-Car M2-N > > + - renesas,irqc-r8a7794 # R-Car E2 > > + - renesas,intc-ex-r8a774a1 # RZ/G2M > > + - renesas,intc-ex-r8a774c0 # RZ/G2E > > + - renesas,intc-ex-r8a7795 # R-Car H3 > > + - renesas,intc-ex-r8a7796 # R-Car M3-W > > + - renesas,intc-ex-r8a77965 # R-Car M3-N > > + - renesas,intc-ex-r8a77970 # R-Car V3M > > + - renesas,intc-ex-r8a77980 # R-Car V3H > > + - renesas,intc-ex-r8a77990 # R-Car E3 > > + - renesas,intc-ex-r8a77995 # R-Car D3 > > + - const: renesas,irqc > > + > > + '#interrupt-cells': > > + # an interrupt index and flags, as defined in interrupts.txt in > > + # this directory > > + const: 2 > > + > > + clocks: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - '#interrupt-cells' > > + - clocks > > Add: > > additionalProperties: false > > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/clock/r8a7790-clock.h> > > + > > + irqc0: interrupt-controller@e61c0000 { > > + compatible = "renesas,irqc-r8a7790", "renesas,irqc"; > > + #interrupt-cells = <2>; > > + interrupt-controller; > > required? > > > + reg = <0 0xe61c0000 0 0x200>; > > Not documented. > > > + interrupts = <0 0 IRQ_TYPE_LEVEL_HIGH>, > > + <0 1 IRQ_TYPE_LEVEL_HIGH>, > > + <0 2 IRQ_TYPE_LEVEL_HIGH>, > > + <0 3 IRQ_TYPE_LEVEL_HIGH>; > > Not documented. > > > + clocks = <&mstp4_clks R8A7790_CLK_IRQC>; > > + }; > > -- > > 1.9.1 > >
