On Tue, Sep 17, 2019 at 05:58:08PM +0200, Marco Felsch wrote: > Currently the driver do not care about the regulator which supplies the > controller. This can lead into problems since we support (deep-)sleep > because the regulator can be turned off before we send the (deep-)sleep > command to the controller. Using a own regulator improves the power > consumption during sleep even more. > + tsdata->vdd = devm_regulator_get(&client->dev, "vdd"); > + if (IS_ERR(tsdata->vdd)) { > + error = PTR_ERR(tsdata->vdd); > + if (error == -EPROBE_DEFER) > + return error; Before it worked w/o regulator. You have to make it optional. > + dev_err(&client->dev, > + "Failed to request vdd-supply, error %d\n", error); > + return error; > + } > + > + error = regulator_enable(tsdata->vdd); > + if (error) { > + dev_err(&client->dev, > + "Failed to enable vdd-supply, error %d\n", error); > + return error; > + } -- With Best Regards, Andy Shevchenko