Hi Simon, On Tue, Sep 17, 2019 at 1:32 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > I missread the original bindings document and somehow missed > warnings emitted by dtbs_check. I now think the compat property should be > described as: > > compatible: > oneOf: > - items: > - enum: > - renesas,thermal-r8a73a4 # R-Mobile APE6 > - renesas,thermal-r8a7779 # R-Car H1 > - const: renesas,rcar-thermal # Without thermal-zone > > - items: > - enum: > - renesas,thermal-r8a7790 # R-Car H2 > - renesas,thermal-r8a7791 # R-Car M2-W > - renesas,thermal-r8a7792 # R-Car V2H > - renesas,thermal-r8a7793 # R-Car M2-N > - const: renesas,rcar-gen2-thermal # With thermal-zone > - const: renesas,rcar-thermal # Without thermal-zone > > - items: > - enum: > - renesas,thermal-r8a7743 # RZ/G1M > - renesas,thermal-r8a7744 # RZ/G1N > - const: renesas,rcar-gen2-thermal # With thermal-zone > > - items: > - enum: > - renesas,thermal-r8a774c0 # RZ/G2E > - renesas,thermal-r8a77970 # R-Car V3M > - renesas,thermal-r8a77990 # R-Car E3 > - renesas,thermal-r8a77995 # R-Car D3 Perhaps we should (try to) get rid of the "Without thermal-zone" legacy? All R-Car Gen2 DTSes received thermal zones a while ago. R-Mobile APE6 and R-Car H1 still don't have them described, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds