Hi Dmitry,
On 19-09-16 12:56, Dmitry Torokhov wrote:
> On Mon, Sep 16, 2019 at 04:03:57PM +0200, Marco Felsch wrote:
> > There was a bug within the driver since commit f889beaaab1c ("Input:
> > da9063 - report KEY_POWER instead of KEY_SLEEP during power
> > key-press"). Since we fixed the bug the KEY_POWER will be reported
> > always so we need to adapt the dt-bindings too. Make the description
> > more precise while on it.
> >
> > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/input/da9062-onkey.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > index d1792452ceff..648b1930df1b 100644
> > --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > @@ -15,9 +15,9 @@ Required properties:
> >
> > Optional properties:
> >
> > -- dlg,disable-key-power : Disable power-down using a long key-press. If this
> > - entry exists the OnKey driver will remove support for the KEY_POWER key
> > - press when triggered using a long press of the OnKey.
> > +- dlg,disable-key-power : Disable host triggered hard shutdown using a long
> > + key-press. If this property isn't present the host will send an i2c shutdown
> > + command on a long key-press.
>
> Can we say what happens when property is present instead? I.e. "If this
> property is present, the host will not be issuing shutdown command over
> I2C in response to a long key-press"?
As you prefer ;)
I will wait for Adam's response and send a v2.
Regards,
Marco
> Thanks.
>
> --
> Dmitry
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
