> > Caution: EXT Email > > On 10/09/2019 18:42:46+0800, Biwen Li wrote: > > Add some properties for pcf85263/pcf85363 as follows: > > - nxp,rtc-interrupt-type: integer type > > - nxp,rtc-interrupt-output-pin: string type > > - quartz-load-femtofarads: integer type > > - nxp,quartz-drive-strength: integer type > > - nxp,quartz-low-jitter: bool type > > - wakeup-source: bool type > > > > Signed-off-by: Martin Fuzzey <mfuzzey@xxxxxxxxxxx> > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx> > > --- > > Change in v4: > > - Drop robust defines in include/dt-bindings/rtc/pcf85363.h > > - Add nxp,rtc-interrupt-type property > > - Replace interrupt-output-pin with nxp,rtc-interrupt-output-pin > > > > Change in v3: > > - None > > > > Change in v2: > > - Replace properties name > > quartz-load-capacitance -> quartz-load-femtofarads > > quartz-drive-strength -> nxp,quartz-drive-strength > > quartz-low-jitter -> nxp,quartz-low-jitter > > - Replace drive strength name > > PCF85263_QUARTZDRIVE_NORMAL -> > PCF85263_QUARTZDRIVE_100ko > > PCF85263_QUARTZDRIVE_LOW -> > PCF85263_QUARTZDRIVE_60ko > > PCF85263_QUARTZDRIVE_HIGH -> > PCF85263_QUARTZDRIVE_500ko > > - Set default interrupt-output-pin as "INTA" > > > > .../devicetree/bindings/rtc/pcf85363.txt | 44 > ++++++++++++++++++- > > include/dt-bindings/rtc/pcf85363.h | 14 ++++++ > > 2 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 > > include/dt-bindings/rtc/pcf85363.h > > > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt > > b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > index 94adc1cf93d9..fc1579463657 100644 > > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > @@ -8,10 +8,52 @@ Required properties: > > Optional properties: > > - interrupts: IRQ line for the RTC (not implemented). > > > > +- nxp,rtc-interrupt-type: integer property, represent the interrupt's > > + type. Valid values are > > + INT_PIE(periodic interrupt enable), > > + INT_OIE(offset correction interrupt enable), > > + INT_A1IE(alarm1 interrupt enable), > > + INT_A2IE(alarm2 interrupt enable), > > + INT_TSRIE(timestamp register interrupt enable) > > + INT_BSIE(battery switch interrupt enable), > > + INT_WDIE(WatchDog interrupt enable,and > > + compose these values such as: INT_A1IE | INT_A2IE, > > + but currently only support INT_A1IE, default value is INT_A1IE. > > + The property and property nxp,rtc-interrupt-output-pin > > + work together to generate some interrupts on some pins. > > + > > +- nxp,rtc-interrupt-output-pin: The interrupt output pin must be > > + "INTA" or "INTB", default value is "INTA". The property and > > +property > > + nxp,rtc-interrupt-type work together to generate some interrupts on > > + some pins. > > + > > This binding still doesn't work because there may be any combination of > interrupts on any of the two pins that this binding doesn't allow. Combination of interrupt maybe need users to select.So it is flexibity. > > > +- quartz-load-femtofarads: The internal capacitor to select for the > > +quartz, > > + expressed in femto Farad (fF). Valid values are 6000, 7000 and 12500. > > + Default value is 12500fF. > > + > > +- nxp,quartz-drive-strength: Drive strength for the quartz, > > + expressed in kilo ohms (kOhm) Valid values are 60, 100 and 500. > > + Default value is 100kOhm. > > + > > It makes more sense to have quartz-drive-strength-ohms as a generic > property. Got it, thanks > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Cbiwen.li%40nxp.com%7C34fc927717674d > 73cd8d08d73b4b577a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > C0%7C637043067081363670&sdata=SXAXKb5qQMf4eXJNB46CGdvh > oA%2F%2BG2r26yYaC2tEGX0%3D&reserved=0
