Hi Biwen, On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@xxxxxxx> wrote: > The patch adds kohms unit > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/property-units.txt > +++ b/Documentation/devicetree/bindings/property-units.txt > @@ -27,6 +27,7 @@ Electricity > -microamp : microampere > -microamp-hours : microampere hour > -ohms : ohm > +-kohms : kiloohm > -micro-ohms : microohm > -microwatt-hours: microwatt hour > -microvolt : microvolt What's your rationale for adding "kohms"? Do you need to specify resistance values that do not fit in 32-bit, and thus cannot be specified using "ohms"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds