Hi, On 17/09/2019 08:07, Qianggui Song wrote: > Add new compatible name for Amlogic's Meson-A1 pin controller > add a dt-binding header file which document the detail pin names. Please add in the commit log that A1 doesn't need the DS bank reg, so when we will convert these bindings to yaml we will be aware of it. > > Signed-off-by: Qianggui Song <qianggui.song@xxxxxxxxxxx> > Signed-off-by: Xingyu Chen <xingyu.chen@xxxxxxxxxxx> > Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx> > --- > .../devicetree/bindings/pinctrl/meson,pinctrl.txt | 1 + > include/dt-bindings/gpio/meson-a1-gpio.h | 73 ++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > create mode 100644 include/dt-bindings/gpio/meson-a1-gpio.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > index 10dc4f7..0aff1f2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > @@ -15,6 +15,7 @@ Required properties for the root node: > "amlogic,meson-axg-aobus-pinctrl" > "amlogic,meson-g12a-periphs-pinctrl" > "amlogic,meson-g12a-aobus-pinctrl" > + "amlogic,meson-a1-periphs-pinctrl" > - reg: address and size of registers controlling irq functionality > > === GPIO sub-nodes === > diff --git a/include/dt-bindings/gpio/meson-a1-gpio.h b/include/dt-bindings/gpio/meson-a1-gpio.h > new file mode 100644 > index 0000000..40e57a5 > --- /dev/null > +++ b/include/dt-bindings/gpio/meson-a1-gpio.h > @@ -0,0 +1,73 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + * Author: Qianggui Song <qianggui.song@xxxxxxxxxxx> > + */ > + > +#ifndef _DT_BINDINGS_MESON_A1_GPIO_H > +#define _DT_BINDINGS_MESON_A1_GPIO_H > + > +#define GPIOP_0 0 > +#define GPIOP_1 1 > +#define GPIOP_2 2 > +#define GPIOP_3 3 > +#define GPIOP_4 4 > +#define GPIOP_5 5 > +#define GPIOP_6 6 > +#define GPIOP_7 7 > +#define GPIOP_8 8 > +#define GPIOP_9 9 > +#define GPIOP_10 10 > +#define GPIOP_11 11 > +#define GPIOP_12 12 > +#define GPIOB_0 13 > +#define GPIOB_1 14 > +#define GPIOB_2 15 > +#define GPIOB_3 16 > +#define GPIOB_4 17 > +#define GPIOB_5 18 > +#define GPIOB_6 19 > +#define GPIOX_0 20 > +#define GPIOX_1 21 > +#define GPIOX_2 22 > +#define GPIOX_3 23 > +#define GPIOX_4 24 > +#define GPIOX_5 25 > +#define GPIOX_6 26 > +#define GPIOX_7 27 > +#define GPIOX_8 28 > +#define GPIOX_9 29 > +#define GPIOX_10 30 > +#define GPIOX_11 31 > +#define GPIOX_12 32 > +#define GPIOX_13 33 > +#define GPIOX_14 34 > +#define GPIOX_15 35 > +#define GPIOX_16 36 > +#define GPIOF_0 37 > +#define GPIOF_1 38 > +#define GPIOF_2 39 > +#define GPIOF_3 40 > +#define GPIOF_4 41 > +#define GPIOF_5 42 > +#define GPIOF_6 43 > +#define GPIOF_7 44 > +#define GPIOF_8 45 > +#define GPIOF_9 46 > +#define GPIOF_10 47 > +#define GPIOF_11 48 > +#define GPIOF_12 49 > +#define GPIOA_0 50 > +#define GPIOA_1 51 > +#define GPIOA_2 52 > +#define GPIOA_3 53 > +#define GPIOA_4 54 > +#define GPIOA_5 55 > +#define GPIOA_6 56 > +#define GPIOA_7 57 > +#define GPIOA_8 58 > +#define GPIOA_9 59 > +#define GPIOA_10 60 > +#define GPIOA_11 61 > + > +#endif /* _DT_BINDINGS_MESON_A1_GPIO_H */ > With that fixed, Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> Neil
