* Sebastian Reichel <sre@xxxxxxxxxx> [190914 13:01]: > Hi, > > On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote: > > Also, we should not call prepare and unprepare except during init, and > > only call enable and disable during use. > > Why? Usually clk_(un)prepare() is the part saving most power, so I > would expect the runtime resume handlers to call clk_prepare_enable > and vice versa in the suspend handler. Sure yeah fine with me, clk_prepare_enable() is more generic at the cost of some extra calls to toggle a clock gate bit :) Let's also forget the probe changes, those will get cleared with the runtime PM changes anyways. Regards, Tony