Re: [Patch 02/13] media: am437x-vpfe: Fix missing first line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans Verkuil <hverkuil@xxxxxxxxx> wrote on Fri [2019-Sep-13 15:00:08 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > Previous generation of this driver were hard coded to handle
> > encoder/decoder were the first line never contains any data and
> 
> were -> where
> 
> > was therefore always skipped, however when dealing with actual
> > camera sensor the first line is always present.
> 
> sensor -> sensors

I'll fix those.

Thanks

Benoit

> 
> Regards,
> 
> 	Hans
> 
> > 
> > Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
> > ---
> >  drivers/media/platform/am437x/am437x-vpfe.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> > index ab959d61f9c9..0ecb75bf5abd 100644
> > --- a/drivers/media/platform/am437x/am437x-vpfe.c
> > +++ b/drivers/media/platform/am437x/am437x-vpfe.c
> > @@ -345,13 +345,9 @@ static void vpfe_ccdc_setwin(struct vpfe_ccdc *ccdc,
> >  	if (frm_fmt == CCDC_FRMFMT_INTERLACED) {
> >  		vert_nr_lines = (image_win->height >> 1) - 1;
> >  		vert_start >>= 1;
> > -		/* Since first line doesn't have any data */
> > -		vert_start += 1;
> >  		/* configure VDINT0 */
> >  		val = (vert_start << VPFE_VDINT_VDINT0_SHIFT);
> >  	} else {
> > -		/* Since first line doesn't have any data */
> > -		vert_start += 1;
> >  		vert_nr_lines = image_win->height - 1;
> >  		/*
> >  		 * configure VDINT0 and VDINT1. VDINT1 will be at half
> > 
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux