On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > > Hi Rahul, > > > > thanks for your patches! > > > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > > <rahul.tanwar@xxxxxxxxxxxxxxx> wrote: > > > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > > Patch 1 adds pinmux & GPIO controller driver. > > > Patch 2 adds the dt bindings document & include file. > > > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > > > OK nice, I think you need to include Mika Westerberg on this review > > as well, because I think he likes to stay on top of all things intel > > in pin control. (Also included two other Intel folks in Finland who usually > > take an interest in these things.) > > Linus, > nevertheless I guess you may give your comments WRT device tree use > (bindings, helpers, etc) along with some basics, (like devm_*() > [ab]use I just noticed). I plan to look at the patches per se but right now I don't have much time because soon there is merge window and kernel summit, the patches just need to age a little bit like a good wine ;) Yours, Linus Walleij
