On Fri, Sep 06, 2019 at 01:54:26PM +0100, Rob Herring wrote:
> On Fri, Sep 6, 2019 at 12:49 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> >
> > On Fri, Sep 06, 2019 at 12:21:58PM +0100, Rob Herring wrote:
> > > On Fri, Sep 6, 2019 at 12:14 PM Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote:
> > > >
> > > > Convert Renesas Product Register bindings documentation to json-schema.
> > > >
> > > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > > > ---
> > > > Based on v5.3-rc1
> > > > Tested using:
> > > > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/renesas,prr.yaml
> > > > ---
> > > > .../devicetree/bindings/arm/renesas,prr.txt | 20 ------------
> > > > .../devicetree/bindings/arm/renesas,prr.yaml | 36 ++++++++++++++++++++++
> > > > 2 files changed, 36 insertions(+), 20 deletions(-)
> > > > delete mode 100644 Documentation/devicetree/bindings/arm/renesas,prr.txt
> > > > create mode 100644 Documentation/devicetree/bindings/arm/renesas,prr.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/renesas,prr.txt b/Documentation/devicetree/bindings/arm/renesas,prr.txt
> > > > deleted file mode 100644
> > > > index 08e482e953ca..000000000000
> > > > --- a/Documentation/devicetree/bindings/arm/renesas,prr.txt
> > > > +++ /dev/null
> > > > @@ -1,20 +0,0 @@
> > > > -Renesas Product Register
> > > > -
> > > > -Most Renesas ARM SoCs have a Product Register or Boundary Scan ID Register that
> > > > -allows to retrieve SoC product and revision information. If present, a device
> > > > -node for this register should be added.
> > > > -
> > > > -Required properties:
> > > > - - compatible: Must be one of:
> > > > - "renesas,prr"
> > > > - "renesas,bsid"
> > > > - - reg: Base address and length of the register block.
> > > > -
> > > > -
> > > > -Examples
> > > > ---------
> > > > -
> > > > - prr: chipid@ff000044 {
> > > > - compatible = "renesas,prr";
> > > > - reg = <0 0xff000044 0 4>;
> > > > - };
> > > > diff --git a/Documentation/devicetree/bindings/arm/renesas,prr.yaml b/Documentation/devicetree/bindings/arm/renesas,prr.yaml
> > > > new file mode 100644
> > > > index 000000000000..9df003041456
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/arm/renesas,prr.yaml
> > > > @@ -0,0 +1,36 @@
> > > > +# SPDX-License-Identifier: GPL-2.0
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/arm/renesas,prr.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Renesas Product Register
> > > > +
> > > > +maintainers:
> > > > + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > > + - Magnus Damm <magnus.damm@xxxxxxxxx>
> > > > +
> > > > +description: |
> > > > + Most Renesas ARM SoCs have a Product Register or Boundary Scan ID
> > > > + Register that allows to retrieve SoC product and revision information.
> > > > + If present, a device node for this register should be added.
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + oneOf:
> > > > + - const: "renesas,prr"
> > > > + - const: "renesas,bsid"
> > >
> > > enum is better than oneOf+const and drop the quotes. oneOf/allOf/anyOf
> > > result in terrible error messages.
> >
> > Thanks Rob,
> >
> > Like this?
> >
> > compatible:
> > enum:
> > - renesas,prr
> > - renesas,bsid
> >
> > > > + reg:
> > > > + items:
> > > > + - description: Base address and length of the register block.
> > >
> > > That's what 'reg' *always* is... Just 'maxItems: 1' is sufficient when
> > > there is" only 1 entry.
> >
> > And this?
> >
> > reg:
> > maxItems: 1
>
> Yes, for both.
Thanks, I have posted v2 with the changes you suggested.
