Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> +module_param_named(debug_mask, ath11k_debug_mask, uint, 0644); >> + >> +MODULE_PARM_DESC(debug_mask, "Debugging mask"); >> + >> +static const struct ath11k_hw_params ath11k_hw_params = { >> + .name = "ipq8074", > > indentation here seems a bit too much > >> +MODULE_LICENSE("Dual BSD/GPL"); > > All your files state "ISC", shouldn't that be reflected here? The MODULE_LICENSE() macro doesn't accept anything else. AFAIK all ISC drivers use this. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches