On Wed, Apr 23, 2014 at 12:27:59PM -0300, Fabio Estevam wrote:
> On Wed, Apr 23, 2014 at 11:58 AM, Felipe Balbi <balbi@xxxxxx> wrote:
>
> > @@ -1658,12 +1657,9 @@ static int serial_omap_probe(struct platform_device *pdev)
> > omap_up_info = of_get_uart_port_info(&pdev->dev);
> > pdev->dev.platform_data = omap_up_info;
> > } else {
> > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > - if (!irq) {
> > - dev_err(&pdev->dev, "no irq resource?\n");
> > - return -ENODEV;
> > - }
> > - uartirq = irq->start;
> > + uartirq = platform_get_irq(pdev, 0);
> > + if (uartirq < 0)
> > + return -EPROBE_DEFER;
>
>
> Maybe you could just do a 'return uartirq' here instead.
I don't mind either way, I'm only returning -EPROBE_DEFER because that's
what the other branch of this conditional returns. Tony, what do you
prefer ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
