Hi Anand, On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > As per shematics HDMI_P5V0 is supplied by P5V0 so add missing link. typo: "schematics" > Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index a078a1ee5004..47789fd50415 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -213,6 +213,8 @@ > status = "okay"; > pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; > pinctrl-names = "default"; > + /* AP2331SA-7 */ > + hdmi-supply = <&p5v0>; > }; my understanding based on odroid-c2_rev0.1_20150930.pdf is that: - there's a (fixed) hdmi_p5v0 regulator using p5v0 as input - the hdmi_p5v0 is the hdmi-supply it doesn't change the functionality of this patch (since both supplies are fixed regulators anyways) you are already doing a nice cleanup with this series, so it would be a shame to take a shortcut here Martin
