On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote: > The software_node_get_parent() returned a pointer to the parent swnode, > but did not take a reference to it, leading the caller to put a reference > that was not taken. Take that reference now. > > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the > firmware node framework") I dunno if scripts parse the split line like above. Nevertheless, for the code prospective looks good to me. Though you probably would like to Cc it to Heikki. -- With Best Regards, Andy Shevchenko