> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: 2019年8月28日 6:26 > To: Xiaowei Bao <xiaowei.bao@xxxxxxx> > Cc: bhelgaas@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; > Leo Li <leoyang.li@xxxxxxx>; kishon@xxxxxx; lorenzo.pieralisi@xxxxxx; > arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; M.h. Lian > <minghuan.lian@xxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxx>; Roy Zang > <roy.zang@xxxxxxx>; jingoohan1@xxxxxxxxx; > gustavo.pimentel@xxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; > andrew.murray@xxxxxxx > Subject: Re: [PATCH v2 04/10] dt-bindings: pci: layerscape-pci: add compatible > strings for ls1088a and ls2088a > > On Thu, Aug 22, 2019 at 07:22:36PM +0800, Xiaowei Bao wrote: > > Add compatible strings for ls1088a and ls2088a. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@xxxxxxx> > > --- > > v2: > > - No change. > > > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > index e20ceaa..16f592e 100644 > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > @@ -22,7 +22,10 @@ Required properties: > > "fsl,ls1043a-pcie" > > "fsl,ls1012a-pcie" > > EP mode: > > - "fsl,ls1046a-pcie-ep", "fsl,ls-pcie-ep" > > + "fsl,ls-pcie-ep" > > Wasn't this a fallback? Each line should be one valid combination of > compatible strings. Thanks, got it, I will modify it in next version patch. Thanks Xiaowei > > > + "fsl,ls1046a-pcie-ep" > > + "fsl,ls1088a-pcie-ep" > > + "fsl,ls2088a-pcie-ep" > > - reg: base addresses and lengths of the PCIe controller register blocks. > > - interrupts: A list of interrupt outputs of the controller. Must contain an > > entry for each entry in the interrupt-names property. > > -- > > 2.9.5 > >
