Hi Oliver, On 19-08-28 18:19, Oliver Graute wrote: > This patch adds DeviceTree Source for the i.MX6 UltraLite DART NAND/WIFI > > Signed-off-by: Oliver Graute <oliver.graute@xxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6ul-var-6ulcustomboard.dts | 196 ++++++++++++++++++++++++ > 2 files changed, 197 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6ul-var-6ulcustomboard.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index a24a6a1..a2a69e4 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -579,6 +579,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ > imx6ul-tx6ul-0010.dtb \ > imx6ul-tx6ul-0011.dtb \ > imx6ul-tx6ul-mainboard.dtb \ > + imx6ul-var-6ulcustomboard.dtb \ > imx6ull-14x14-evk.dtb \ > imx6ull-colibri-eval-v3.dtb \ > imx6ull-colibri-wifi-eval-v3.dtb \ > diff --git a/arch/arm/boot/dts/imx6ul-var-6ulcustomboard.dts b/arch/arm/boot/dts/imx6ul-var-6ulcustomboard.dts > new file mode 100644 > index 00000000..1861b34 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6ul-var-6ulcustomboard.dts > @@ -0,0 +1,196 @@ > +// SPDX-License-Identifier: (GPL-2.0) > +/* > + * Support for Variscite DART-6UL Module > + * > + * Copyright (C) 2015 Freescale Semiconductor, Inc. > + * Copyright (C) 2015-2016 Variscite Ltd. - http://www.variscite.com > + * Copyright (C) 2018-2019 Oliver Graute <oliver.graute@xxxxxxxxx> > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/input/input.h> > +#include "imx6ul-imx6ull-var-dart-common.dtsi" > + > +/ { > + model = "Variscite i.MX6 UltraLite Carrier-board"; > + compatible = "variscite,6ulcustomboard", "fsl,imx6ul"; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm1 0 20000>; > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <6>; > + status = "okay"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + user { > + gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; Please mux the gpios where you need them. In this case mux it within the gpio-keys node. > + linux,code = <KEY_BACK>; > + gpio-key,wakeup; > + }; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + > + d16-led { > + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>; The same applies here. > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "wm8731audio"; > + simple-audio-card,widgets = > + "Headphone", "Headphone Jack", > + "Line", "Line Jack", > + "Microphone", "Mic Jack"; > + simple-audio-card,routing = > + "Headphone Jack", "RHPOUT", > + "Headphone Jack", "LHPOUT", > + "LLINEIN", "Line Jack", > + "RLINEIN", "Line Jack", > + "MICIN", "Mic Bias", > + "Mic Bias", "Mic Jack"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,bitclock-master = <&sound_master>; > + simple-audio-card,frame-master = <&sound_master>; > + > + sound_master: simple-audio-card,cpu { > + sound-dai = <&sai2>; > + }; Where is the codec node? > + }; > +}; > + > +&can1 { > + status = "okay"; We need to move the complete muxing from the SoM dtsi to the baseboard for all baseboard related nodes.. I tought that the Dart 6UL layout follows a specific standard but that isn't the case. > +}; > + > +&can2 { > + status = "okay"; > +}; > + > +&fec1 { > + phy-mode = "rgmii"; This avoid such re-assigning here too. Also the imx6ul only support 10/100 Mbit/s. So rgmii makes no sense here. > + phy-reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > + phy-handle = <ðphy0>; > + status = "okay"; > +}; > + > +&fec2 { > + phy-mode = "rgmii"; > + phy-reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; > + phy-handle = <ðphy1>; > + status = "okay"; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; > + status = "okay"; > +}; > + > +&i2c2 { > + clock_frequency = <100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + > + wm8731: audio-codec@1a { > + #sound-dai-cells = <0>; Please move #sound-dai-cells below compatible and reg property. > + compatible = "wlf,wm8731"; > + reg = <0x1a>; > + clocks = <&clks IMX6UL_CLK_SAI2>; > + clock-names = "mclk"; > + }; > + > + touchscreen@38 { > + compatible = "edt,edt-ft5x06"; > + reg = <0x38>; > + interrupt-parent = <&gpio3>; > + interrupts = <4 0>; Make use of IRQ_TYPE_* > + touchscreen-size-x = <800>; > + touchscreen-size-y = <480>; > + touchscreen-inverted-x; > + touchscreen-inverted-y; > + wakeup-source; > + }; > + > + rtc@68 { > + compatible = "dallas,ds1337"; > + reg = <0x68>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rtc>; > + interrupt-parent = <&gpio5>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; > + > +&lcdif { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcdif>; > + display = <&display0>; > + status = "okay"; > + > + display0: display0 { > + bits-per-pixel = <16>; > + bus-width = <24>; > + > + display-timings { > + native-mode = <&timing0>; > + timing0: timing0 { > + clock-frequency =<35000000>; > + hactive = <800>; > + vactive = <480>; > + hfront-porch = <40>; > + hback-porch = <40>; > + hsync-len = <48>; > + vback-porch = <29>; > + vfront-porch = <13>; > + vsync-len = <3>; > + hsync-active = <0>; > + vsync-active = <0>; > + de-active = <1>; > + pixelclk-active = <0>; > + }; > + }; > + }; > +}; > + > +&pwm1 { > + status = "okay"; > +}; > + > +&uart1 { > + status = "okay"; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&uart3 { > + status = "okay"; > +}; > + > +&usbotg1 { > + dr_mode = "host"; > + status = "okay"; > +}; > + > +&usbotg2 { > + dr_mode = "host"; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl_rtc: rtcgrp { > + fsl,pins = < > + MX6UL_PAD_SNVS_TAMPER7__GPIO5_IO07 0x1b0b0 > + >; > + }; As I said above, move the complete muxing pwm/usb/i2c/lcd/... from the som dtsi to the baseboard dts because it is only valid for this baseboard. Another baseboard using this som can have a complete different mux option. Regards, Marco > +}; > -- > 2.7.4 > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
