-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 8/27/19 2:25 PM, Valdis Kl?tnieks wrote: > On Mon, 26 Aug 2019 10:42:52 -0500, Dinh Nguyen said: >> The primecell controller on some SoCs, i.e. SoCFPGA, is held in >> reset by default. Until recently, the DMA controller was brought >> out of reset by the bootloader(i.e. U-Boot). But a recent change >> in U-Boot, the peripherals that are not used are held in reset >> and are left to Linux to bring them out of reset. >> >> Add a mechanism for getting the reset property and de-assert the >> primecell module from reset if found. This is a not a hard fail >> if the reset properti is not present in the device tree node, so >> the driver will continue to probe. > > Does this DTRT for both old and new U-Boots? My naive reading of > this patch What is a DTRT? > says on an old U-Boot, we end up attempting to bring it out of > reset even though they had already been brought out. > If the peripheral is already out of reset, de-asserting the reset has no affect. Dinh -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoHhMeiyk5VmwVMwNGZQEC4GjKPQFAl1mgtYACgkQGZQEC4Gj KPRKMRAArFO9bQ7FCE4oiVgO/sOLm2M/ngGD3Czi6Y8TcAbIk4EylBGVw634Gs4Z v5vuyxShlfApBb0PqfhLOo5cXrTyMdpWOq9AQ4vEcEU2MPKN8QcyLczvEagyYcwA ianhTLR21v1Gdfm5MHqpKrNxSrb6Nt6cWmYCXjpabLYZg0gKJnsYl2XheHIdUJ02 kD2P6sQC3mf3OC5Gou4JXZGvDMgEwLG9lHsb7YoFq6tzZW3YQvAi3HcxIZZh4J8b jFcPR3RxxQgGwESEGDWQu2EzY/d9qStEQ9VYHl/v6QIL77S1oXUAXLbh3e6ZoSgt M93eK2G9wGCL5JlUbHXQ402OfewHchgQW1bDpjkaZLL+d9jUiGLqALAj0Az2FqX1 HtPPtifB4z6TuaLkxNTZ1Oz7UR0cWtKeSYjsuIwi0XzQMXopgH7oKdzJajNlAfRJ In6fSVuwp47p43wj2dmUtuCSYvzKTHAg/sVGaufEfsT8ZINSOZJY9ivDqkJIzlDR nsOclhfOGs5PgL4NPFW5U5O58DzZ5yl9NEotB4ahacuOqJv1PUdT3gABbL5hUogx QTAPNREbYesG3osFLeEXeachiNChyJ7r+NyWFly7RXA/ukxoer2Rkxt3h0hQib6Q /jhAsa1ar1NEk8dJJfNO7R5pZkG7ZCbhzuSDKPB2yRZPDeQGol8= =SFzc -----END PGP SIGNATURE-----
