On Wed, Apr 23, 2014 at 10:26:20AM +0900, YoungJun Cho wrote: > Hi Andrzej > > Thank you for comment. > > On 04/22/2014 11:02 PM, Andrzej Hajda wrote: > >On 04/21/2014 02:28 PM, YoungJun Cho wrote: > >>This patch adds DT bindings for s6e3fa0 panel. > >>The bindings describes panel resources, display timings and cpu timings. > >> > >>Changelog v2: > >>- Adds unit address (commented by Sachin Kamat) > >>Changelog v3: > >>- Removes optional delay, size properties (commented by Laurent Pinchart) > >>- Adds OLED detection, TE gpio properties > >>Changelog v4: > >>- Moves CPU timings relevant properties from FIMD DT > >> (commeted by Laurent Pinchart, Andrzej Hajda) > >> > >>Signed-off-by: YoungJun Cho <yj44.cho@xxxxxxxxxxx> > >>Acked-by: Inki Dae <inki.dae@xxxxxxxxxxx> > >>Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >>--- > >> .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 63 ++++++++++++++++++++ > >> 1 file changed, 63 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > >> > >>diff --git a/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > >>new file mode 100644 > >>index 0000000..9eeb38b > >>--- /dev/null > >>+++ b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > >>@@ -0,0 +1,63 @@ > >>+Samsung S6E3FA0 AMOLED LCD 5.7 inch panel > >>+ > >>+Required properties: > >>+ - compatible: "samsung,s6e3fa0" > >>+ - reg: the virtual channel number of a DSI peripheral > >>+ - vdd3-supply: core voltage supply > >>+ - vci-supply: voltage supply for analog circuits > >>+ - reset-gpio: a GPIO spec for the reset pin > >>+ - det-gpio: a GPIO spec for the OLED detection pin > >>+ - te-gpio: a GPIO spec for the TE pin > > > >Just FYI, according to DT documentation [1] gpio spec should be in form > >[name]-gpios, however there is plenty bindings with -gpio suffix, so I > >am not sure if it is really enforced. On the other side it is enforced > >by descriptor based gpio framework[2]. Integer-based gpio framework > >used in your driver is obsolete according to [2]. > > Yes, you're right. That is my mistake. > They should be attached 's'. > At first I used integer-based gpio framework and replaced to descriptor > based one, but did not updated DT bindings. I've been working on a patch to support both *-gpios and *-gpio variants with the GPIO descriptor framework. *-gpios makes sense if there can indeed be several, but for something like hotplug detection I don't think there's a reason to require the plural. Furthermore some bindings already use the singular *-gpio anyway, so if we ever want to convert drivers using those bindings to the GPIO descriptor API we have to support that form too. Thierry
Attachment:
pgpv7dSaQVWHe.pgp
Description: PGP signature
