Hi, Rui > On Tue, 2019-08-27 at 01:51 +0000, Anson Huang wrote: > > > On 7/30/2019 5:31 AM, Anson.Huang@xxxxxxx wrote: > > > > From: Anson Huang <Anson.Huang@xxxxxxx> > > > > > > > > Some platforms like i.MX8MQ has clock control for this module, > > > > need to add clock operations to make sure the driver is working > > > > properly. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > > Reviewed-by: Guido Günther <agx@xxxxxxxxxxx> > > > > > > This series looks good, do you think it can be merged in time for > > > v5.4? > > > Today was v5.3-rc6. > > > > If the question is for me, then I am NOT sure, the thermal patches are > > pending there for almost half year and I did NOT receive any response, > > which patch series you're referring to? Below i.MX8QXP patch series, I meant I started it from last year, the latest resend version is 2 months ago: https://patchwork.kernel.org/patch/11000809/ > > > looks like no one > > is maintaining the thermal sub-system? Below two patch series are also pending there for some time: https://patchwork.kernel.org/patch/11032777/ https://patchwork.kernel.org/patch/11031297/ > > > > Eduardo is maintaining all the thermal-soc driver changes. Thus I usually > filtered out the soc driver patches in my mailbox. > > The last email from Eduardo is that he is offline during this July and will be > back and taking patches in August. > > I will double check with Eduardo anyway. Thanks, especially our i.MX8QXP thermal driver patch, I started it from last year and due to some different opinion from different reviewers, this patch series version is up to v15, but I did NOT receive response since June, appreciated if you guys can take a look at this, I ping it many times but no feedback. Thanks! https://patchwork.kernel.org/patch/11000809/ Anson. > > thanks, > rui > > > > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from the > > > TMU clock so if the thermal driver doesn't explicitly enable it the > > > system will hang on probe. This is what happens in linux-next right > > > now! > > > > The thermal driver should be built with module, so default kernel > > should can boot up, do you modify the thermal driver as built-in? > > > > > > > > Unless this patches is merged soon we'll end up with a 5.4-rc1 that > > > doesn't boot on imx8mq. An easy fix would be to drop/revert commit > > > 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for > > > IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted. > > > > If the thermal driver is built as module, I think no need to revert > > the commit, but if by default thermal driver is built-in or mod > > probed, then yes, it should NOT break kernel boot up. > > > > Anson. > > > > > > > > Merging patches out-of-order when they have hard (boot-breaking) > > > dependencies also breaks bisect. > > > > > > -- > > > Regards, > > > Leonard
