Hi Rob, On 22/08/19 2:32 AM, Rob Herring wrote: > On Fri, Aug 09, 2019 at 01:59:46PM +0530, Lokesh Vutla wrote: >> Add pinctrl macros for J721E SoC. These macro definitions are >> similar to that of AM6, but adding new definitions to avoid >> any naming confusions in the soc dts files. >> >> Acked-by: Nishanth Menon <nm@xxxxxx> >> Signed-off-by: Lokesh Vutla <lokeshvutla@xxxxxx> >> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx> >> --- >> include/dt-bindings/pinctrl/k3.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h >> index 45e11b6170ca..499de6216581 100644 >> --- a/include/dt-bindings/pinctrl/k3.h >> +++ b/include/dt-bindings/pinctrl/k3.h >> @@ -32,4 +32,7 @@ >> #define AM65X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> #define AM65X_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> >> +#define J721E_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> +#define J721E_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > checkpatch reports a parentheses error: (((pa) & 0x1fff) ((val) | (muxmode))) This was left intentionally as this macro is giving out two entries in DT like below: pinctrl-single,pins = < J721E_IOPAD(0x0, PIN_INPUT, 7) >; comes out as pinctrl-single,pins = < 0x0 (PIN_INPUT | 7) >; If parenthesis are added for the whole macro, the following build error occurs: DTC arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb Error: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:41.24-25 syntax error FATAL ERROR: Unable to parse input tree Thanks and regards, Lokesh
