Hi Jacopo, Thank you for the patch. How about changing the subject to "drm: rcar-du: Document DT backward compatibility" ? On Sun, Aug 25, 2019 at 04:01:35PM +0200, Jacopo Mondi wrote: > Exand comment in the 'vsps' parsing routine to specify why the LIF s/Exand/Expand/ > channel index is defaulted to 0 in case the second cell of the property s/is defaulted to 0/defaults to 0/ > is not specified. You could explain it here too :-) > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 2dc9caee8767..0d59f390de19 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -585,7 +585,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu) > > vsps[j].crtcs_mask |= BIT(i); > > - /* Store the VSP pointer and pipe index in the CRTC. */ > + /* > + * Store the VSP pointer and pipe index in the CRTC. If the > + * second cell of the 'vsps' specifier isn't present, default > + * to 0 to remain compatible with older DT bindings. > + */ > rcdu->crtcs[i].vsp = &rcdu->vsps[j]; > rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0; > } -- Regards, Laurent Pinchart
