On Thu, Aug 22, 2019 at 8:12 PM Sean Wang <sean.wang@xxxxxxxxxx> wrote: > On Mon, Aug 19, 2019 at 2:22 AM Mars Cheng <mars.cheng@xxxxxxxxxxxx> wrote: > > > > This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core. > > > > Signed-off-by: Mars Cheng <mars.cheng@xxxxxxxxxxxx> > > Signed-off-by: Andy Teng <andy.teng@xxxxxxxxxxxx> > > Acked-by: Sean Wang <sean.wang@xxxxxxxxxx> Please look at the DT bindings as well when you have time, and especially the "virtual GPIO" patch, I don't understand that at all. I suspect the "virtual GPIO" is maybe more about something that should be done by setting up the valid_mask in the gpio_chip or something. Yours, Linus Walleij