Hi Kishon, Kishon Vijay Abraham I <kishon@xxxxxx> wrote on Fri, 23 Aug 2019 08:46:14 +0530: > On 31/07/19 5:51 PM, Miquel Raynal wrote: > > Armada CP110 have a COMPHY IP which supports configuring SERDES lanes > > in one mode, either: > > - SATA > > - USB3 host > > - PCIe (several width) > > - Ethernet (several modes) > > > > As of today, only a few Ethernet modes are supported and the code is > > embedded in the Linux driver. A more complete COMPHY driver that can > > be used by both Linux and U-Boot is embedded in the firmware and can > > be run through SMC calls. > > > > First the current COMPHY driver is updated to use SMC calls but > > fallbacks to the already existing functions if the firmware is not > > up-to-date. Then, more Ethernet modes are added (through SMC calls > > only). SATA, USB3H and PCIe modes are also supported one by one. > > > > There is one subtle difference with the PCIe functions: we must tell > > the firmware the number of lanes to configure (x1, x2 or x4). This > > parameter depends on the number of entries in the 'phys' property > > describing the PCIe PHY. We use the "submode" parameter of the generic > > PHY API to carry this value. The Armada-8k PCIe driver has been > > updated to follow this idea and this change has been merged already: > > http://patchwork.ozlabs.org/patch/1072763/ > > Some of the patches are not applying cleanly. Care to resend the series after > rebasing to phy -next? Sure, I'll do it asap. Thanks! Miquèl
