Hi Jacopo, On Fri, Aug 23, 2019 at 8:31 AM Jacopo Mondi <jacopo@xxxxxxxxxx> wrote: > On Fri, Aug 23, 2019 at 03:12:09AM +0300, Laurent Pinchart wrote: > > On Thu, Aug 22, 2019 at 09:56:00PM +0200, Jacopo Mondi wrote: > > > According to the Renesas R-Car DU bindings documentation, the 'vsps' > > > property should be composed by a phandle to the VSP instance and the > > > > > index of the LIF channel assigned to the DU channel. Some SoC device > > > tree source files do not specify any LIF channel index, relying on the > > > driver defaulting it to 0 if not specified. > > > > > > Align all device tree files by specifying the LIF channel index as > > > prescribed by the bindings documentation. While at it, add a comment to > > > the 'vsps' property parsing routine to point out the LIF channel index > > > is still defaulted to 0 for backward compatibility with non-standard DTB > > > found in the wild. > > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > Note that Simon or Geert will likely ask you to split this patch in two, > > in which case I'll take the driver part in my tree. > > I was not sure how to split this in facts.. Simon, Geert, would you > like a v2 with DT changes separated from the driver comment update? Yes please. > (for the DT changes, one patch per SoC, or a single one?) One patch for all SoCs is fine: arm64: dts: renesas: Add LIF channel indices to vsps properties Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds