On 22/08/2019 20:34:14+0800, Ran Bi wrote: > > > + /* RTC need POWERKEY1/2 match, then goto normal work mode */ > > > + mt2712_writel(rtc, MT2712_POWERKEY1, MT2712_POWERKEY1_KEY); > > > + mt2712_writel(rtc, MT2712_POWERKEY2, MT2712_POWERKEY2_KEY); > > > > This should be written when setting the time after power was lost. > > > > I suppose we can move this into mt2712_rtc_read_time function's "if > (p1 != MT2712_POWERKEY1_KEY || p2 != MT2712_POWERKEY2_KEY)" condition > which will be added at next patch. We need additional flag to mark this > condition or another if condition in mt2712_rtc_set_time fucntion if we > put these code in mt2712_rtc_set_time function. > It is fine to test both in read_time and in set_time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
