Kevin Hilman <khilman@xxxxxxxxxxxx> writes: > Guillaume La Roque <glaroque@xxxxxxxxxxxx> writes: > >> This patchs series add support of New Amlogic temperature sensor and minimal >> thermal zone for SEI510 and ODROID-N2 boards. >> >> First implementation was doing on IIO[1] but after comments i move on thermal framework. >> Formulas and calibration values come from amlogic. >> >> Changes since v2: >> - fix yaml documention >> - remove unneeded status variable for temperature-sensor node >> - rework driver after Martin review >> - add some information in commit message >> >> Changes since v1: >> - fix enum vs const in documentation >> - fix error with thermal-sensor-cells value set to 1 instead of 0 >> - add some dependencies needed to add cooling-maps >> >> Dependencies : >> - patch 3,4 & 5: depends on Neil's patch and series : >> - missing dwc2 phy-names[2] >> - patchsets to add DVFS on G12a[3] which have deps on [4] and [5] >> >> [1] https://lore.kernel.org/linux-amlogic/20190604144714.2009-1-glaroque@xxxxxxxxxxxx/ >> [2] https://lore.kernel.org/linux-amlogic/20190625123647.26117-1-narmstrong@xxxxxxxxxxxx/ >> [3] https://lore.kernel.org/linux-amlogic/20190729132622.7566-1-narmstrong@xxxxxxxxxxxx/ >> [4] https://lore.kernel.org/linux-amlogic/20190731084019.8451-5-narmstrong@xxxxxxxxxxxx/ >> [5] https://lore.kernel.org/linux-amlogic/20190729132622.7566-3-narmstrong@xxxxxxxxxxxx/ > > Thank you for the detailed list of dependencies! Much appreciated. > > With all the deps, I tested this on sei510 and odroid-n2, and basic > functionality seems to work. > > As discussed off-list: it would be nice to have an example of how > cpufreq could be used as a cooling device for hot temperatures. The > vendor kernel has some trip points that could be included as examples, > or even included as extra patches. > > Also the driver patch is missing the two main thermal maintainers, so > please resend at least the driver and bindings including them. Forgot to add... Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
