On Tue, Aug 20, 2019 at 03:27:39PM -0500, Rob Herring wrote: > > I see. If I understand the schema correctly, this should look like: > > Looks correct, but a couple of comments. > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7294ac36f4c0..eb263d1ccf13 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -161,6 +161,22 @@ properties: > > items: > > - enum: > > - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > Is the SOM ever used alone? If not, then no point in listing this here. SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons. Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere. > > > + - const: fsl,imx6ul > > + > > + - description: Kontron N6310 S Board > > + items: > > + - enum: > > + - kontron,imx6ul-n6310-s > > This could be a 'const' instead. It depends if you think there will > ever be more than one entry. Indeed, I'll make this and entry below for S 43 board const. Best regards, Krzysztof
