On Tue, Apr 22, 2014 at 08:21:35AM +0200, Robert Baldyga wrote: > On 04/19/2014 12:52 PM, Aaro Koskinen wrote: > > Hi, > > > > On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote: > >> dev_info(&pdev->dev, > >> - "OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n", > >> - (rev >> 4) & 0xf, rev & 0xf, config->extcon, otg_dev->id, > >> + "OMAP USB OTG controller rev %d.%d (id=%d, vbus=%d)\n", > >> + (rev >> 4) & 0xf, rev & 0xf, otg_dev->id, > >> otg_dev->vbus); > > > > This change is unrelated to the patch and not needed. > > > > It's related because we no longer use config->extcon since we have > cable-oriented API. We can keep displaying it, but this value is > actually meaningless. can you just add some note in the commit log ? "while at that, also remove config->extconf from debugging print because it won't contain valid data anymore" or something like that. Other than that: Acked-by: Felipe Balbi <balbi@xxxxxx> -- balbi
Attachment:
signature.asc
Description: Digital signature
