Hi Rob, thanks for the rewiew. On Tue, 2019-08-20 at 12:16 -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 9:58 AM Nicolas Saenz Julienne > <nsaenzjulienne@xxxxxxx> wrote: > > Provides the same functionality as of_machine_is_compatible. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> > > --- > > > > Changes in v2: None > > > > drivers/of/fdt.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > index 9cdf14b9aaab..06ffbd39d9af 100644 > > --- a/drivers/of/fdt.c > > +++ b/drivers/of/fdt.c > > @@ -802,6 +802,13 @@ const char * __init of_flat_dt_get_machine_name(void) > > return name; > > } > > > > +static const int __init of_fdt_machine_is_compatible(char *name) > > No point in const return (though name could possibly be const), and > the return could be bool instead. Sorry, I completely missed that const, shouldn't have been there to begin with. I'll add a const to the name argument and return a bool on the next version. Regards, Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
